Changes section in stable

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Changes section in stable

Francisco Vila
Hello, regarding to changes section in Stable, now online:

English looks perfect, obviously.

Links in Català give 404

cs, de, fr, hu, zh, nl, and ja links lead to English version

Spanish Split gives 404, Bigpage leads to an empty (titled) page and PDF
link leads to a empty (titled) PDF. Sources are translated.

Italiano looks perfect. As in English, Split and Bigpage look the same
because there is no sectioning in the original.

I'll investigate this now.

--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

David Kastrup
Francisco Vila <[hidden email]> writes:

> Hello, regarding to changes section in Stable, now online:
>
> English looks perfect, obviously.
>
> Links in Català give 404
>
> cs, de, fr, hu, zh, nl, and ja links lead to English version
>
> Spanish Split gives 404, Bigpage leads to an empty (titled) page and
> PDF link leads to a empty (titled) PDF. Sources are translated.
>
> Italiano looks perfect. As in English, Split and Bigpage look the same
> because there is no sectioning in the original.
>
> I'll investigate this now.

I think that the diagnostics produced at the end of make doc by issue
<https://sourceforge.net/p/testlilyissues/issues/5822/> would help a
_whole_ lot with that investigation.

At least as long as you take care to keep the size calculation macros
@docSize in sync with the documentation cross references via @docLinks
et al.

In the translations, the links need to get redirected to
language-specific versions.  Depending on the language, Partly this
happens by changing the macros creating the documentation links (I think
that should likely be the most sensible way), partly it happens by
changing the _invocations_ of those macros, and partly it happens half
by accident, namely the link being formally for an English version and
the translator not noticing it because their browser preferences and the
settings of the Apache web server combine to deliver a nationalised
version instead.

If you change the invocations of the macros, the size calculations of
issue 5822 will work out of the box, but I doubt that is the best way.

I was leary about having issue 5822 go into master, but I think we are
not likely doing ourselves a favor by not doing so: it corrects some
problems and fingerpoints a number of other problems pretty well.  What
problems with doing the actual website may remain, is hard to diagnose
without seeing the actual website.  But the worst damage that can happen
to the web site is that the out-of-date size specs disappear temporarily
for links that are currently dead, or at least only visible due to
browser language settings.

--
David Kastrup


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
El 8/3/20 a las 21:04, David Kastrup escribió:
> In the translations, the links need to get redirected to
> language-specific versions.  Depending on the language, Partly this
> happens by changing the macros creating the documentation links (I think
> that should likely be the most sensible way), partly it happens by
> changing the_invocations_  of those macros,

Generated file Documentation/LL/out-www/weblinks.itexi is identical for
all LL languages, so one could think the difference must rely only on
choosing the right incovation. But on second thougth, the macros
themselves could still be wrong, because different languages use
different macros.

Anyway. I expected wrongly to see translated es/changes showing online,
but this will only happpen when the second stable minor version occurrs.
Right?

--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Jean-Charles MALAHIEUDE
Le 09/03/2020 à 18:21, Francisco Vila a écrit :
> Anyway. I expected wrongly to see translated es/changes showing
> online, but this will only happpen when the second stable minor
> version occurrs. Right?
>

Wrong! translation has to be merged into master and then the website
regenerated.

And I'm about to first merge master into translation (you'll have one
more item in changes.tely BTW).

Cheers
--
Jean-Charles


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

David Kastrup
Jean-Charles Malahieude <[hidden email]> writes:

> Le 09/03/2020 à 18:21, Francisco Vila a écrit :
>> Anyway. I expected wrongly to see translated es/changes showing
>> online, but this will only happpen when the second stable minor
>> version occurrs. Right?
>>
>
> Wrong! translation has to be merged into master and then the website
> regenerated.

I think Francisco is talking about 2.18–2.20 changes, not 2.20–2.22
changes.  I really have no clue just when and how the _stable_
documentation makes it into our web pages.

--
David Kastrup


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
El 9/3/20 a las 20:37, David Kastrup escribió:

> Jean-Charles Malahieude <[hidden email]> writes:
>
>> Le 09/03/2020 à 18:21, Francisco Vila a écrit :
>>> Anyway. I expected wrongly to see translated es/changes showing
>>> online, but this will only happpen when the second stable minor
>>> version occurrs. Right?
>>>
>>
>> Wrong! translation has to be merged into master and then the website
>> regenerated.
>
> I think Francisco is talking about 2.18–2.20 changes, not 2.20–2.22
> changes.

True, the latter is devel- , but devel now in the page is 2.19 (= future
2.20) so changes page in devel section is still "2.20 since 2.18".

404 also for me in http://lilypond.org/website/development.es.html BTW.

> I really have no clue just when and how the _stable_
> documentation makes it into our web pages.

Mmm, tricky. It shouldn't be an obscure manual process.


--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
El 10/3/20 a las 10:36, Phil Holmes escribió:
>
> It's not an obscure manual process, it's an obscure automatic process.  
> I built 2.20 with GUB, uploaded it with GUB and it automatically created
> the "stable" docs and opposed to the unstable ones.


I have just built docs from stable branch and Manuals page says "Manuals
for LilyPond 2.20.0". Then I go to  Community/Development and it says
"Development for LilyPond 2.20.0" as well. So it is still a bit obscure
to me, how the online web hosts a mix of stable and devel, which branch
is it built from?

--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
In reply to this post by Francisco Vila
Here is what Details page of Changes looks like in locally-built docs
from stable branch, for every language.

ca: Split now leads to English version. Bigpage and PDF links give 404.

cs: Split in English, Bigpage and PDF are 404 now

fr: Split and Bigpage are now translated. PDF is in English (the link
text is changes.fr.pdf but the URL is changes.pdf)

it, ja: Split and Bigpage are now translated. PDF is in English

hu, zh, nl, pt: Split in English, Bigpage is 404, PDF is in English.

es: translated

So at least one works. I'd like to see how this all is carried to the
online version once it is uploaded. I cross fingers.

I initially thought it was all a matter of correct macro choice in
web/manuals.itexi;

under

   @unnumberedsec [Changes in English]
   @translationof Changes
   ...
   @docLinks{
   ...

one should use

   @manualStableChangesSplit-LL
   @manualStableChangesBig-LL
   @manualStableChangesPdf-LL

where LL is your language, _if_ your sources are translated.

But to my surprise, ja/web/manuals.itexi has

   @manualStableChangesSplit
   @manualStableChangesBig
   @manualStableChangesPdf

with no -ja suffix (!)

So at least in this case, it must be in macro *generation*, not in macro
*invocation* where the magic happens.

Still lost in this labyrinth. Stay tuned



Should I stick to translations list only for this?


El 8/3/20 a las 20:32, Francisco Vila escribió:
 > Hello, regarding to changes section in Stable, now online:
 >
 > English looks perfect, obviously.
 >
 > Links in Català give 404>
 > cs, de, fr, hu, zh, nl, and ja links lead to English version> Spanish
Split gives 404, Bigpage leads to an empty (titled) page
 > and PDF link leads to a empty (titled) PDF. Sources are translated.
 >
 > Italiano looks perfect. As in English, Split and Bigpage look the same
 > because there is no sectioning in the original.
 >

--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
El 10/3/20 a las 20:39, Francisco Vila escribió:
> it, ja: Split and Bigpage are now translated. PDF is in English
...
> But to my surprise, ja/web/manuals.itexi has
>
>    @manualStableChangesSplit
>    @manualStableChangesBig
>    @manualStableChangesPdf
>
> with no -ja suffix (!)

And Italian uses the -it suffix on all three macros.

--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

David Kastrup
In reply to this post by Francisco Vila
Francisco Vila <[hidden email]> writes:

> Here is what Details page of Changes looks like in locally-built docs
> from stable branch, for every language.

Master will in short time gain a patch making lots of complaints at the
end of build doc (because it tries looking up the sizes of referenced
files and fails).  That should be helpful.

I think this will also get cherry-picked into the stable branch
eventually: makes no sense having wrong sizes there.  But it might make
sense getting the links into order in the master branch first.

--
David Kastrup


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
El 10/3/20 a las 23:09, David Kastrup escribió:

> Francisco Vila <[hidden email]> writes:
>
>> Here is what Details page of Changes looks like in locally-built docs
>> from stable branch, for every language.
>
> Master will in short time gain a patch making lots of complaints at the
> end of build doc (because it tries looking up the sizes of referenced
> files and fails).  That should be helpful.
>
> I think this will also get cherry-picked into the stable branch
> eventually: makes no sense having wrong sizes there.  But it might make
> sense getting the links into order in the master branch first.

OK, I'll wait. In the meantime, I am very puzzled by the following.
Let's take Italian as a good example. In manuals/changes page, PDF link is

    (...)/build/out-www/offline-root/Documentation/changes.pdf

therefore English version. If I manually change that to

    (...)/build/out-www/offline-root/Documentation/changes.it.pdf

we get a nice translated Italian PDF. But this link is coded as the
@manualStableChangesPdf-it macro in source file manuals.itexi. Now I
look at it/weblinks.itexi and the definition for that macro is

   ../doc/v2.20/Documentation/changes.it.pdf

How in Earth has this been changed to the first link above?




--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Federico Bruni-3


Il giorno mer 11 mar 2020 alle 11:15, Francisco Vila
<[hidden email]> ha scritto:

> El 10/3/20 a las 23:09, David Kastrup escribió:
>> Francisco Vila <[hidden email]> writes:
>>
>>> Here is what Details page of Changes looks like in locally-built
>>> docs
>>> from stable branch, for every language.
>>
>> Master will in short time gain a patch making lots of complaints at
>> the
>> end of build doc (because it tries looking up the sizes of referenced
>> files and fails).  That should be helpful.
>>
>> I think this will also get cherry-picked into the stable branch
>> eventually: makes no sense having wrong sizes there.  But it might
>> make
>> sense getting the links into order in the master branch first.
>
> OK, I'll wait. In the meantime, I am very puzzled by the following.
> Let's take Italian as a good example. In manuals/changes page, PDF
> link is
>
>    (...)/build/out-www/offline-root/Documentation/changes.pdf
>
> therefore English version. If I manually change that to
>
>    (...)/build/out-www/offline-root/Documentation/changes.it.pdf
>
> we get a nice translated Italian PDF. But this link is coded as the
> @manualStableChangesPdf-it macro in source file manuals.itexi. Now I
> look at it/weblinks.itexi and the definition for that macro is
>
>   ../doc/v2.20/Documentation/changes.it.pdf
>
> How in Earth has this been changed to the first link above?
>

I tried to debug it a few weeks ago but could not find an explanation.
You might see that PDF file path is localized for catalan, french and
spanish pages only, while the other languages are linking to the
english file.





Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
In reply to this post by Francisco Vila
El 11/3/20 a las 11:15, Francisco Vila escribió:

> OK, I'll wait. In the meantime, I am very puzzled by the following.
> Let's take Italian as a good example. In manuals/changes page, PDF link is
>
>     (...)/build/out-www/offline-root/Documentation/changes.pdf
>
> therefore English version. If I manually change that to
>
>     (...)/build/out-www/offline-root/Documentation/changes.it.pdf
>
> we get a nice translated Italian PDF. But this link is coded as the
> @manualStableChangesPdf-it macro in source file manuals.itexi. Now I
> look at it/weblinks.itexi and the definition for that macro is
>
>    ../doc/v2.20/Documentation/changes.it.pdf
>
> How in Earth has this been changed to the first link above?


A part of the answer is: make website, then check links in

   (...)build/out-website/website/changes.it.html

There, all links give 'file not found' but at least they look correct
for their use online. Link to Italian PDF now potentially leads to an
actual translated PDF.

Now, on to check other languages.

--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es


Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Federico Bruni-3


Il giorno mer 11 mar 2020 alle 15:41, Francisco Vila
<[hidden email]> ha scritto:

> El 11/3/20 a las 11:15, Francisco Vila escribió:
>> OK, I'll wait. In the meantime, I am very puzzled by the following.
>> Let's take Italian as a good example. In manuals/changes page, PDF
>> link is
>>
>>     (...)/build/out-www/offline-root/Documentation/changes.pdf
>>
>> therefore English version. If I manually change that to
>>
>>     (...)/build/out-www/offline-root/Documentation/changes.it.pdf
>>
>> we get a nice translated Italian PDF. But this link is coded as the
>> @manualStableChangesPdf-it macro in source file manuals.itexi. Now
>> I look at it/weblinks.itexi and the definition for that macro is
>>
>>    ../doc/v2.20/Documentation/changes.it.pdf
>>
>> How in Earth has this been changed to the first link above?
>
>
> A part of the answer is: make website, then check links in
>
>   (...)build/out-website/website/changes.it.html
>
> There, all links give 'file not found' but at least they look correct
> for their use online. Link to Italian PDF now potentially leads to an
> actual translated PDF.
>
> Now, on to check other languages.
>

Links are correct in the top website (generated by make website?):
http://lilypond.org/changes.it.html
http://lilypond.org/development.it.html

But not here:
http://lilypond.org/doc/v2.19/Documentation/web/changes.it.html
http://lilypond.org/doc/v2.19/Documentation/web/development.it.html

Of course duplication is nonsense.
Honestly, I'm not interested in trying to understand this mess.
No surprise there's nobody working on lilypond website since a long
time.





Reply | Threaded
Open this post in threaded view
|

Re: Changes section in stable

Francisco Vila
El 12/3/20 a las 0:16, Federico Bruni escribió:
> Links are correct in the top website (generated by make website?):
> http://lilypond.org/changes.it.html
> http://lilypond.org/development.it.html
>
This is stable. Italian performs optimally here. Spanish does not. The
code is already there, just it has to be built and uploaded.


> But not here:
> http://lilypond.org/doc/v2.19/Documentation/web/changes.it.html
> http://lilypond.org/doc/v2.19/Documentation/web/development.it.html
>
> Of course duplication is nonsense.

This is old development version, to be replaced soon by 2.21. Same as before


--
Francisco Vila, Ph.D. - Badajoz (Spain)
paconet.org , lilypond.es