Doc-ja NR: adding some sections

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Doc-ja NR: adding some sections

Yoshiki Sawada
Hello everyone,

I send a new patch for Japanese NR.
Please check and push it.

Thanks,
Yoshiki Sawada

0001-Doc-ja-adding-simultaneous.itely-and-staff.itely.patch (119K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Francisco Vila
2011/4/28 Yoshiki Sawada <[hidden email]>:
> Hello everyone,
>
> I send a new patch for Japanese NR.
> Please check and push it.

I have pushed it, thanks!

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Yoshiki Sawada
Hello,

I send a new patch.
Please check and push it.

I have finished to translate the chapter Music notation :)

Thanks,
Yoshiki Sawada (Japan)

0002-Doc-ja-Adding-two-sections-to-NR-ja.patch (121K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Francisco Vila
2011/5/1 Yoshiki Sawada <[hidden email]>:
> Hello,
>
> I send a new patch.
> Please check and push it.
>
> I have finished to translate the chapter Music notation :)
>

Could you strip all leading spaces?

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Yoshiki Sawada
Hello Francisco,

I want to do what you said.
But I do not know which spaces I should delete.
Please tell me about them.

----
Yoshiki Sawada (Japan)

Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Francisco Vila
2011/5/2 Yoshiki Sawada <[hidden email]>:
> Hello Francisco,
>
> I want to do what you said.
> But I do not know which spaces I should delete.

Lines of code should not have spaces at the end.  Your patch contained
many; it is not really harmful but git shows a warning and it is best
practice to strimp them.

For each file modified in your latest patch, do

  scripts/auxiliar/strip-whitespace.py Documentation/ja/your_file

then, 'git diff' will tell you what has been done.  You could 'git
commit --amend' after this and send a new patch, for example.

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Yoshiki Sawada
I am sure.
Thank you!

I have fixed my files and re-made a patch.
Please check it.

Thanks,
Yoshiki Sawada (Japan)


0002-Doc-ja-Adding-two-sections-to-NR-ja.patch (259K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Doc-ja NR: adding some sections

Francisco Vila
2011/5/3 Yoshiki Sawada <[hidden email]>:
> I am sure.
> Thank you!
>
> I have fixed my files and re-made a patch.
> Please check it.

Perfect; applied and pushed.


--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com