[PATCH] Doc-ja: Adding Notation Reference

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Doc-ja: Adding Notation Reference

Yoshiki Sawada
Hello John and all,

I created a patch to add Japanese NR.
I made it by copying English "notation.tely" and typing
"make ISOLANG=ja skeleton-update".

I added few translations to "ja/notation.tely".
If my patch works correctly, I'll add progresses to my translations.
If not, I'll re-make it.

Sincerely,
Yoshiki Sawada


0001-Doc-ja-Adding-Japanese-Notation-Reference.patch (263K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Doc-ja: Adding Notation Reference

John Mandereau
Hello Sawada,
Le dimanche 17 janvier 2010 à 11:58 +0900, Yoshiki Sawada a écrit :
> I created a patch to add Japanese NR.
> I made it by copying English "notation.tely" and typing
> "make ISOLANG=ja skeleton-update".

Sorry, the Contributors' Guide is fairly outdated.  I'm fixing this and
skeleton-update (although only in a roughly way) as well.  You may well
junk all .itely files and reread the Note I put some time ago on
translating cross-references.

Besides this, could you also copy ja/learning/GNUmakefile to
ja/notation/GNUmakefile and add notation to ja/GBUmakefile SUBDIRS?


> I added few translations to "ja/notation.tely".

You may also want to translate the copyright notice and menu entries
too, but I guess you're planning to do this anyway.  Other than this it
looks good.


> If my patch works correctly, I'll add progresses to my translations.

It would be cleaner not to add a commit that contains files in English
in ja/ directory; if you do, then never pull until you have no longer
documentation file in English in ja/ and commit changes with option
--amend (you can also commit with option --amend at intermediary stages
before you're ready to send me a patch).

Best wishes,
John

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [translations] [PATCH] Doc-ja: Adding Notation Reference

John Mandereau
Le lundi 18 janvier 2010 à 22:59 +0100, John Mandereau a écrit :
> It would be cleaner not to add a commit that contains files in English
> in ja/ directory; if you do, then never pull until you have no longer
> documentation file in English in ja/ and commit changes with option
> --amend (you can also commit with option --amend at intermediary stages
> before you're ready to send me a patch).

Oops, shame on me.  I'm sorry, I just saw I wrote the contrary in the
Contributors' Guide several years ago, I just fixed this.  There is no
reason to pull from git.sv.gnu.org while you are in the middle of
working on the initial translation, except if by my fault there is a
revision of lilypond/translation that doesn't compile succesfully, and
you happened to create your Git repository at that moment.

By the way, after the next patch I will apply from you, we'll request
Git push access for you.

All the best,
John

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [translations] [PATCH] Doc-ja: Adding Notation Reference

Yoshiki Sawada
Hello John,

Thank you for your instructions.
With intention to follow them, I created a new patch for Japanese NR.
How about it?

I have a will to re-work it again when it does not work well.

Sincerely,
Yoshiki Sawada

0001-Doc-ja-Adding-Japanese-NR.patch (15K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [translations] [PATCH] Doc-ja: Adding Notation Reference

John Mandereau
Le samedi 23 janvier 2010 à 23:43 +0900, Yoshiki Sawada a écrit :
> Hello John,
>
> Thank you for your instructions.
> With intention to follow them, I created a new patch for Japanese NR.
> How about it?

It looks good, except that I can't believe that I overlooked the
renaming instructions about appending '@c external' to the argument of
@translationof, which is no longer necessary and even confuses the
script that generate HTML file names map.  I just pushed a fix in the
Contributor's Guide for this.

All the rest of your patch looks perfect.

Thank you sincerely for your patience and determination.
All the best,
John

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [translations] [PATCH] Doc-ja: Adding Notation Reference

Yoshiki Sawada
It looks good, except that I can't believe that I overlooked the
renaming instructions about appending '@c external' to the argument of
@translationof, which is no longer necessary and even confuses the
script that generate HTML file names map.  I just pushed a fix in the
Contributor's Guide for this.
 
Yes! I did it :)
I can re-make the patch after removing [hidden email] external's.
Should I do that?
 
 
All the rest of your patch looks perfect.

Thank you sincerely for your patience and determination.
All the best,
John

 
I thank you too for your patience.
 
Thanks,
Yoshiki Sawada
Reply | Threaded
Open this post in threaded view
|

Re: [translations] [PATCH] Doc-ja: Adding Notation Reference

John Mandereau
Le mercredi 27 janvier 2010 à 12:47 +0900, Yoshiki Sawada a écrit :
> Yes! I did it :)
> I can re-make the patch after removing '@c external's.
> Should I do that?

Yes, please :-)

Best,
John Mandereau



signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [translations] [PATCH] Doc-ja: Adding Notation Reference

Yoshiki Sawada
I send a new patch.
Check it out, please.

Sincerely,
Yoshiki Sawada


2010/1/27 John Mandereau <[hidden email]>
Le mercredi 27 janvier 2010 à 12:47 +0900, Yoshiki Sawada a écrit :
> Yes! I did it :)
> I can re-make the patch after removing '@c external's.
> Should I do that?

Yes, please :-)

Best,
John Mandereau




0001-Doc-ja-Adding-Japanese-NR-Retry.patch (15K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Doc-ja: Adding Notation Reference

John Mandereau
2010/1/27 Yoshiki Sawada <[hidden email]>:
> I send a new patch.
> Check it out, please.

It looks good, please keep this commit in your history, and you can
commit further changes in newer commits as usual.

Thanks,
John


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Doc-ja: Adding Notation Reference

Yoshiki Sawada


2010/1/28 John Mandereau <[hidden email]>
It looks good, please keep this commit in your history, and you can
commit further changes in newer commits as usual.

I'm sure.
Thank you ;-)

Sincerely,
Yoshiki Sawada
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Doc-ja: Adding Notation Reference

Yoshiki Sawada
Should I do something for adding my patch to lilypong.git?
Or can I make new patches for adding translations?

Sincerely,
Yoshiki Sawada

2010/1/28 Yoshiki Sawada <[hidden email]>


2010/1/28 John Mandereau <[hidden email]>

It looks good, please keep this commit in your history, and you can
commit further changes in newer commits as usual.

I'm sure.
Thank you ;-)

Sincerely,
Yoshiki Sawada