Re: Catalan translation priority 1 (issue 102170048)

classic Classic list List threaded Threaded
33 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-08 0:14 GMT+02:00 James <[hidden email]>:

> On 07/06/14 19:09, [hidden email] wrote:
>> I'm contributing the Catalan translation of the Documentation. I have
>> translated (I believe) all files in Priority 1.
>>
>> https://codereview.appspot.com/102170048/
>>
>> _______________________________________________
>> lilypond-devel mailing list
>> [hidden email]
>> https://lists.gnu.org/mailman/listinfo/lilypond-devel
> I am fwding to the translation list who know how to handle this type of
> request (as per the contributor's guide).
>
> http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#translating-the-documentation

Thanks, James.

Walter, I will create a new Doc language after a few checks. Will take
care of this as soon as I find a time window.

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
> Walter, I will create a new Doc language after a few checks. Will take
> care of this as soon as I find a time window.

Speaking of, regarding some other languages, I think highly
unmaintained material should possibly be marked for a careful deletion
after having talked to latest known contributors to them.

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
* Francisco Vila, [hidden email] [08/06/14 01:58]:
> > Walter, I will create a new Doc language after a few checks. Will take
> > care of this as soon as I find a time window.

Thanks.

Did I use the right procedure to contribute the translations, that is
create the patches and upload them to an issue (I did it with git-cl)?
Should I keep using this procedure to add other translated files or
update my existing translations? Should I have send the message of the
issue to this list instead than to the developer's list?

Or is there another procedure all together?

Thanks,

--
Walter Garcia-Fontes



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-08 7:04 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
> Did I use the right procedure to contribute the translations, that is
> create the patches and upload them to an issue (I did it with git-cl)?

That is the best possible procedure in general. Only we translators do
not use it too much because the best person to comment on translated
material is the translator itself. Rietveld is more aimed to
crowd-reviewing and commenting code inline, then the author usually
takes the patch set and pushes it by himself.

In your case, while you completed the Priority One task and your work
ends here, that is not enough for having a new language in the web. I
still must add it to the web building infrastructure. Then, the whole
thing should compile with zero errors.

Besides, can you build the docs on your system to test your own patches?

> Should I keep using this procedure to add other translated files or
> update my existing translations?

As a new translator, it is more usual that you send the patches
directly to me. The patch should apply cleanly on translation branch
HEAD.

> Should I have send the message of the
> issue to this list instead than to the developer's list?

You can use devel- for topics of interest there and should use
translations list for topics of interest here.

Welcome,
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
* Francisco Vila, [hidden email] [08/06/14 10:34]:
> Besides, can you build the docs on your system to test your own patches?

Thanks, I built the docs in my system and after correcting a couple of
mistakes in Documentation/po/ca.po it completed OK.

I've uploaded the corrected set of patches to the original issue:
https://codereview.appspot.com/102170048

Patch set 3.

Now: I couldn't see any "ca" related new files in the built tree. The
make showed me the errors in ca.po, but then it seems that no "ca"
texinfo or pdf files were built. Is that OK?

--
Walter Garcia-Fontes
L'Hospitalet de Llobregat



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Federico Bruni-2
2014-06-09 10:21 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
Now: I couldn't see any "ca" related new files in the built tree. The
make showed me the errors in ca.po, but then it seems that no "ca"
texinfo or pdf files were built. Is that OK?

No, you should see a Documentation/ca/ directory in your build dir.
I don't know what is wrong and I can't test your patch because Rietveld says that it's too big to download it at once.

Maybe you can upload somewhere a single patch created with:

git format-patch origin

?

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
* Federico Bruni, [hidden email] [09/06/14 11:29]:

> 2014-06-09 10:21 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
>
> > Now: I couldn't see any "ca" related new files in the built tree. The
> > make showed me the errors in ca.po, but then it seems that no "ca"
> > texinfo or pdf files were built. Is that OK?
> >
>
> No, you should see a Documentation/ca/ directory in your build dir.
> I don't know what is wrong and I can't test your patch because Rietveld
> says that it's too big to download it at once.

Thanks Federico, I do see Documentation/ca/ in my build dir, with some
subdirs, but there is nothing there so I think there is a problem with
my build even if it finished with no error.

I've uploaded my files in a tar-gzip archive, to be decompressed with
"tar -xzvf ca.patch.tgz", it can be downloaded  from :

http://puna.upf.edu/ca.patch.tgz

If the format is not fine please tell me, I can also create a "zip" if
you prefer,

--
Walter Garcia-Fontes
L'Hospitalet de Llobregat



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-09 11:58 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:

> * Federico Bruni, [hidden email] [09/06/14 11:29]:
>> 2014-06-09 10:21 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
>>
>> > Now: I couldn't see any "ca" related new files in the built tree. The
>> > make showed me the errors in ca.po, but then it seems that no "ca"
>> > texinfo or pdf files were built. Is that OK?
>> >
>>
>> No, you should see a Documentation/ca/ directory in your build dir.
>> I don't know what is wrong and I can't test your patch because Rietveld
>> says that it's too big to download it at once.
>
> Thanks Federico, I do see Documentation/ca/ in my build dir, with some
> subdirs, but there is nothing there so I think there is a problem with
> my build even if it finished with no error.

There is probably no problem with your build other than it is not
possible to build the docs without the necessary infrastructure. As I
said, your translated files are not all that is needed; for example,
there are lists here and there with the language codes to build.
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
* Francisco Vila, [hidden email] [09/06/14 12:05]:

> 2014-06-09 11:58 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
> > * Federico Bruni, [hidden email] [09/06/14 11:29]:
> >> 2014-06-09 10:21 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
> >>
> >> > Now: I couldn't see any "ca" related new files in the built tree. The
> >> > make showed me the errors in ca.po, but then it seems that no "ca"
> >> > texinfo or pdf files were built. Is that OK?
> >> >
> >>
> >> No, you should see a Documentation/ca/ directory in your build dir.
> >> I don't know what is wrong and I can't test your patch because Rietveld
> >> says that it's too big to download it at once.
> >
> > Thanks Federico, I do see Documentation/ca/ in my build dir, with some
> > subdirs, but there is nothing there so I think there is a problem with
> > my build even if it finished with no error.
>
> There is probably no problem with your build other than it is not
> possible to build the docs without the necessary infrastructure. As I
> said, your translated files are not all that is needed; for example,
> there are lists here and there with the language codes to build.

Thanks, I installed all the dependencies listed in the documentation,
and followed (I think) all the instructions to add a new translation.

Anyway, I wait for you or Federico to try my patches and tell me if
there is any problem. At least your advise made me correct a couple of
wrong line endings in Documenation/po/ca.po.

--
Walter Garcia-Fontes
L'Hospitalet de Llobregat


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-09 12:27 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:

> * Francisco Vila, [hidden email] [09/06/14 12:05]:
>> There is probably no problem with your build other than it is not
>> possible to build the docs without the necessary infrastructure. As I
>> said, your translated files are not all that is needed; for example,
>> there are lists here and there with the language codes to build.
>
> Thanks, I installed all the dependencies listed in the documentation,
> and followed (I think) all the instructions to add a new translation.
>
> Anyway, I wait for you or Federico to try my patches and tell me if
> there is any problem. At least your advise made me correct a couple of
> wrong line endings in Documenation/po/ca.po.

It is not a matter of dependencies. I have to enable your language in
a number of places of the build scripts. Give me some time, please be
patient.
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Federico Bruni-2
In reply to this post by Walter Garcia-Fontes

2014-06-09 12:27 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
Anyway, I wait for you or Federico to try my patches and tell me if
there is any problem. At least your advise made me correct a couple of
wrong line endings in Documenation/po/ca.po.


Hi Walter, see below.
First, some files should not be in web/

$ git status
Sul branch translation
Il tuo branch è avanti rispetto a 'origin/translation' di 17 commit.
  (use "git push" to publish your local commits)

Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

    deleted:    ca/web/common-macros.itexi
    deleted:    ca/web/cyrillic.itexi
    deleted:    ca/web/macros.itexi

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   ../python/langdefs.py


Second, you forgot to add ca in langdefs.py:

fede@federico:~/lilypond-git/Documentation$ git diff
diff --git a/python/langdefs.py b/python/langdefs.py
index 51c38de..7511ffb 100644
--- a/python/langdefs.py
+++ b/python/langdefs.py
@@ -74,8 +74,8 @@ zh = LanguageDef ('zh', '中文', enable_ly_identifier_l10n=False)
 # (please run 'make doc-clean' before doing that):
 #fr.enabled = False
 
-LANGUAGES = (site, cs, de, es, fr, hu, it, ja, nl, zh)
-WEB_LANGUAGES = (site, cs, de, es, fr, hu, it, ja, nl, zh)
+LANGUAGES = (site, ca, cs, de, es, fr, hu, it, ja, nl, zh)
+WEB_LANGUAGES = (site, ca, cs, de, es, fr, hu, it, ja, nl, zh)
 
 if os.getenv("MAKEWEB") == '1':
     LANGUAGES=WEB_LANGUAGES


Now, ca is recognized but I'm getting this error:

$ cat Documentation/ca/web.splittexi.log
Processing web site: [ca]
** closing qq (2 braces missing) (l. 346)
** `Introduccció' doesn't appear in menus
** `Top' is up for `Introduccció', but has no menu entry for this node
WARNING: Unable to load the map file
WARNING: Unable to find node 'Introducció' in book .
WARNING: Unable to find node 'Introducció' in book .
*** Undefined node `Introducció' in @ref (l. 133 in @divClass)
Max error number exceeded

Do you know how to debug it?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
* Federico Bruni, [hidden email] [09/06/14 16:56]:
> 2014-06-09 12:27 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
>
> > Anyway, I wait for you or Federico to try my patches and tell me if
> > there is any problem. At least your advise made me correct a couple of
> > wrong line endings in Documenation/po/ca.po.
> >

Thanks Federico for your comments, I try to take a look and see if I
can figure it out.

I think I can have a try to debug it.

> Hi Walter, see below.
> First, some files should not be in web/
>
> $ git status
> Sul branch translation
> Il tuo branch è avanti rispetto a 'origin/translation' di 17 commit.
>   (use "git push" to publish your local commits)
>
> Changes to be committed:
>   (use "git reset HEAD <file>..." to unstage)
>
>     deleted:    ca/web/common-macros.itexi
>     deleted:    ca/web/cyrillic.itexi
>     deleted:    ca/web/macros.itexi
>
> Changes not staged for commit:
>   (use "git add <file>..." to update what will be committed)
>   (use "git checkout -- <file>..." to discard changes in working directory)
>
>     modified:   ../python/langdefs.py
>
>
> Second, you forgot to add ca in langdefs.py:
>
> fede@federico:~/lilypond-git/Documentation$ git diff
> diff --git a/python/langdefs.py b/python/langdefs.py
> index 51c38de..7511ffb 100644
> --- a/python/langdefs.py
> +++ b/python/langdefs.py
> @@ -74,8 +74,8 @@ zh = LanguageDef ('zh', '中文',
> enable_ly_identifier_l10n=False)
>  # (please run 'make doc-clean' before doing that):
>  #fr.enabled = False
>
> -LANGUAGES = (site, cs, de, es, fr, hu, it, ja, nl, zh)
> -WEB_LANGUAGES = (site, cs, de, es, fr, hu, it, ja, nl, zh)
> +LANGUAGES = (site, ca, cs, de, es, fr, hu, it, ja, nl, zh)
> +WEB_LANGUAGES = (site, ca, cs, de, es, fr, hu, it, ja, nl, zh)
>
>  if os.getenv("MAKEWEB") == '1':
>      LANGUAGES=WEB_LANGUAGES
>
>
> Now, ca is recognized but I'm getting this error:
>
> $ cat Documentation/ca/web.splittexi.log
> Processing web site: [ca]
> ** closing qq (2 braces missing) (l. 346)
> ** `Introduccció' doesn't appear in menus
> ** `Top' is up for `Introduccció', but has no menu entry for this node
> WARNING: Unable to load the map file
> WARNING: Unable to find node 'Introducció' in book .
> WARNING: Unable to find node 'Introducció' in book .
> *** Undefined node `Introducció' in @ref (l. 133 in @divClass)
> Max error number exceeded
>
> Do you know how to debug it?

--
Walter Garcia-Fontes
mailto: [hidden email] - http://puna.upf.edu
Departament d'Economia i Empresa - http://www.econ.upf.edu
Universitat Pompeu Fabra
Ramon Trias Fargas 25-27, 08005 Barcelona, Spain
Tel. +34 93 542 2722 - Fax. +34 93 542 1746



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Federico Bruni-2
In reply to this post by Federico Bruni-2

2014-06-09 16:56 GMT+02:00 Federico Bruni <[hidden email]>:
Now, ca is recognized but I'm getting this error:

$ cat Documentation/ca/web.splittexi.log
Processing web site: [ca]
** closing qq (2 braces missing) (l. 346)
** `Introduccció' doesn't appear in menus
** `Top' is up for `Introduccció', but has no menu entry for this node
WARNING: Unable to load the map file
WARNING: Unable to find node 'Introducció' in book .
WARNING: Unable to find node 'Introducció' in book .
*** Undefined node `Introducció' in @ref (l. 133 in @divClass)
Max error number exceeded

Do you know how to debug it?



$ cd Documentation/ca/web/
fede@federico:~/lilypond-git/Documentation/ca/web$ git grep -n 'Introducc*'
community.itexi:803:@headitem Introducció
introduction.itexi:11:@node Introducció
introduction.itexi:12:@unnumbered Introducció
introduction.itexi:13:@translationof Introduction
manuals.itexi:18:@subheading Introduction
manuals.itexi:95:@subheading Introductory questions

This is just a typo, it's easy.
The 2 brace missing error is more tricky
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
In reply to this post by Francisco Vila
* Federico Bruni, [hidden email] [09/06/14 17:15]:

> 2014-06-09 16:56 GMT+02:00 Federico Bruni <[hidden email]>:
>
> > Now, ca is recognized but I'm getting this error:
> >
> > $ cat Documentation/ca/web.splittexi.log
> > Processing web site: [ca]
> > ** closing qq (2 braces missing) (l. 346)
> > ** `Introduccció' doesn't appear in menus
> > ** `Top' is up for `Introduccció', but has no menu entry for this node
> > WARNING: Unable to load the map file
> > WARNING: Unable to find node 'Introducció' in book .
> > WARNING: Unable to find node 'Introducció' in book .
> > *** Undefined node `Introducció' in @ref (l. 133 in @divClass)
> > Max error number exceeded
> >
> > Do you know how to debug it?
>
> $ cd Documentation/ca/web/
> fede@federico:~/lilypond-git/Documentation/ca/web$ git grep -n 'Introducc*'
> community.itexi:803:@headitem Introducció
> introduction.itexi:11:@node Introducció
> introduction.itexi:12:@unnumbered Introducció
> introduction.itexi:13:@translationof Introduction
> manuals.itexi:18:@subheading Introduction
> manuals.itexi:95:@subheading Introductory questions
>
> This is just a typo, it's easy.
> The 2 brace missing error is more tricky

Thanks again Federico, it seems that now I'm on track. After
correcting the langdef.py file, I was able to start bulding the new ca
documentation and correct the bracesd problem, but some more errors
popped up after successive "make doc". So hold on, I will try to
correct those and see if I can have a clean "make doc" before
proceeding.

I will post again my patches after that.

--
Walter Garcia-Fontes
L'Hospitalet de Llobregat


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

David Kastrup
Walter Garcia-Fontes <[hidden email]> writes:

> Thanks again Federico, it seems that now I'm on track. After
> correcting the langdef.py file, I was able to start bulding the new ca
> documentation and correct the bracesd problem, but some more errors
> popped up after successive "make doc". So hold on, I will try to
> correct those and see if I can have a clean "make doc" before
> proceeding.
>
> I will post again my patches after that.

Starting a new language is a large undertaking, and maintaining it is as
well.  Currently the translations which are maintained timely and
extensively are Italian and Spanish.  It would be great to add Catalan
to that mixture even though it might make people ask "what's up with
LilyPond and Romance languages"?

If somebody adds an Occitan translation now, maybe some non-Romance
language families can be challenged into taking up the pen either again
or for the first time...

--
David Kastrup


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
* David Kastrup, [hidden email] [09/06/14 20:27]:
> If somebody adds an Occitan translation now, maybe some non-Romance
> language families can be challenged into taking up the pen either again
> or for the first time...

Well, still showing up how strong the Roman Empire was in Europe...

--
Walter Garcia-Fontes
L'Hospitalet de Llobregat


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Walter Garcia-Fontes
In reply to this post by Walter Garcia-Fontes
* Walter Garcia-Fontes, [hidden email] [09/06/14 20:06]:
> * Federico Bruni, [hidden email] [09/06/14 17:15]:
> > 2014-06-09 16:56 GMT+02:00 Federico Bruni <[hidden email]>:
> >
> > > Now, ca is recognized but I'm getting this error:

...

> Thanks again Federico, it seems that now I'm on track. After
> correcting the langdef.py file, I was able to start bulding the new ca
> documentation and correct the bracesd problem, but some more errors
> popped up after successive "make doc". So hold on, I will try to
> correct those and see if I can have a clean "make doc" before
> proceeding.
>
> I will post again my patches after that.

Well, I think I've debugged my set of translations. I've posted again
my set of patches to:

http://puna.upf.edu/ca.patches.tgz

--
Walter Garcia-Fontes
L'Hospitalet de Llobregat


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-11 22:13 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
> Well, I think I've debugged my set of translations. I've posted again
> my set of patches to:
>
> http://puna.upf.edu/ca.patches.tgz

I'm afraid I get a 404 error here.

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-12 1:22 GMT+02:00 Francisco Vila <[hidden email]>:
> 2014-06-11 22:13 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
>> Well, I think I've debugged my set of translations. I've posted again
>> my set of patches to:
>>
>> http://puna.upf.edu/ca.patches.tgz
>
> I'm afraid I get a 404 error here.

Or, is it "patch.tgz" like the previous one?

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Catalan translation priority 1 (issue 102170048)

Francisco Vila
2014-06-12 1:24 GMT+02:00 Francisco Vila <[hidden email]>:

> 2014-06-12 1:22 GMT+02:00 Francisco Vila <[hidden email]>:
>> 2014-06-11 22:13 GMT+02:00 Walter Garcia-Fontes <[hidden email]>:
>>> Well, I think I've debugged my set of translations. I've posted again
>>> my set of patches to:
>>>
>>> http://puna.upf.edu/ca.patches.tgz
>>
>> I'm afraid I get a 404 error here.
>
> Or, is it "patch.tgz" like the previous one?

There are lots of whitespace warnings; I can handle this with another
patch. Worse, I obtain the following

*** '}' without opening '{' before:
Max error number exceeded

error. Could you find/fix it?

--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com


12
Loading...