Workflow with Lilypond on GitLab

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Workflow with Lilypond on GitLab

Caio Barros
Hey, everyone!

I've been following the dev mailing list and I saw that Lilypond is now hosted on GitLab, right? In this case, wouldn't it make more sense for us to change our workflow and start doing merge requests to the translation branch instead of sending the patch directly to the mailing list?

I don't know, I was just thinking about that now. We can, of course, still discuss the modifications here, but I think using merge requests will be more straightforward.

Caio

Reply | Threaded
Open this post in threaded view
|

Re: Workflow with Lilypond on GitLab

David Kastrup
Caio Barros <[hidden email]> writes:

> Hey, everyone!
>
> I've been following the dev mailing list and I saw that Lilypond is now
> hosted on GitLab, right? In this case, wouldn't it make more sense for us
> to change our workflow and start doing merge requests to the translation
> branch instead of sending the patch directly to the mailing list?
>
> I don't know, I was just thinking about that now. We can, of course, still
> discuss the modifications here, but I think using merge requests will be
> more straightforward.

My suggestion would be that those who want to do it in that manner go
ahead and try, posting the resulting links here and look at the feedback
in mailing list as well as on Gitlab.  We can try converging to a
preferred workflow in the time of a few weeks (not just for translations
but also the rest of development) and then try to describe it in the CG
and prescribe it for general use.

I would not feel comfortable prescribing anything just yet as I first
need to get the hang of the platform and its possibilities.  So I'd
suggest that we first discover how things may go and exchange
experiences before trying to figure out some workflow we are comfortable
suggesting everyone to use.

--
David Kastrup


Reply | Threaded
Open this post in threaded view
|

Re: Workflow with Lilypond on GitLab

Caio Barros
Em seg., 11 de mai. de 2020 às 10:18, David Kastrup <[hidden email]> escreveu:
I would not feel comfortable prescribing anything just yet as I first
need to get the hang of the platform and its possibilities.  So I'd
suggest that we first discover how things may go and exchange
experiences before trying to figure out some workflow we are comfortable
suggesting everyone to use.

Ok, agreed with that. In any case. It seems that I'm unable to create merge requests. Not sure if that's because I'm a new contributor, which I totally understand, but I wanted to try out the merge request thing.

@Frederico, what do you think? Should I send my next patch here or can you give me permission in gitlab?

Thanks!
Reply | Threaded
Open this post in threaded view
|

Re: Workflow with Lilypond on GitLab

Federico Bruni-3


Il giorno mar 12 mag 2020 alle 17:05, Caio Barros
<[hidden email]> ha scritto:

> Em seg., 11 de mai. de 2020 às 10:18, David Kastrup <[hidden email]>
> escreveu:
>> I would not feel comfortable prescribing anything just yet as I first
>>  need to get the hang of the platform and its possibilities.  So I'd
>>  suggest that we first discover how things may go and exchange
>>  experiences before trying to figure out some workflow we are
>> comfortable
>>  suggesting everyone to use.
>
> Ok, agreed with that. In any case. It seems that I'm unable to create
> merge requests. Not sure if that's because I'm a new contributor,
> which I totally understand, but I wanted to try out the merge request
> thing.
>
> @Frederico, what do you think? Should I send my next patch here or
> can you give me permission in gitlab?
>

What's your username on gitlab.com?
Let us know and Jonas will add you to the members' list¹.

I think the merge request is better because it cannot get lost and
forgotten as it may happen with an email. Also, in the past someone
applied a translation patch sent on the mailing list without replying
on the mailing list (so I lost some time checking that the patch was
already pushed; with a MR this wouldn't happen).
That said, I agree with David that we should leave open the chance to
send a patch here in the mailing list, in case someone prefers this way.


¹ https://gitlab.com/lilypond/lilypond/-/project_members





Reply | Threaded
Open this post in threaded view
|

Re: Workflow with Lilypond on GitLab

Caio Barros
Em ter., 12 de mai. de 2020 às 18:12, Federico Bruni <[hidden email]> escreveu:


Il giorno mar 12 mag 2020 alle 17:05, Caio Barros
<[hidden email]> ha scritto:

> Em seg., 11 de mai. de 2020 às 10:18, David Kastrup <[hidden email]>
> escreveu:
>> I would not feel comfortable prescribing anything just yet as I first
>>  need to get the hang of the platform and its possibilities.  So I'd
>>  suggest that we first discover how things may go and exchange
>>  experiences before trying to figure out some workflow we are
>> comfortable
>>  suggesting everyone to use.
>
> Ok, agreed with that. In any case. It seems that I'm unable to create
> merge requests. Not sure if that's because I'm a new contributor,
> which I totally understand, but I wanted to try out the merge request
> thing.
>
> @Frederico, what do you think? Should I send my next patch here or
> can you give me permission in gitlab?
>

What's your username on gitlab.com?
Let us know and Jonas will add you to the members' list.

over there I'm @caiobarros [1]
 
I think the merge request is better because it cannot get lost and
forgotten as it may happen with an email. Also, in the past someone
applied a translation patch sent on the mailing list without replying
on the mailing list (so I lost some time checking that the patch was
already pushed; with a MR this wouldn't happen).
That said, I agree with David that we should leave open the chance to
send a patch here in the mailing list, in case someone prefers this way.

Alright. I agree!

Reply | Threaded
Open this post in threaded view
|

Re: Workflow with Lilypond on GitLab

Caio Barros
In reply to this post by Federico Bruni-3
Forgot to copy the list in the reply

Em qua., 13 de mai. de 2020 às 17:12, Caio Barros <[hidden email]> escreveu:
Em qua., 13 de mai. de 2020 às 03:39, Jonas Hahnfeld <[hidden email]> escreveu:
Note that we don't need people to be in the group to submit merge
requests: You can just fork the repository, push your own and branch
and submit it from there. That's already used to great success with
several new contributors.
 
Oh ok, nice to know. I confess all of my projects on GitLab are just mine, without any collaborators, so I was not familiar with that.